Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bunch of code that did things in a slightly incorrect and/or outdated way, this PR fixes them -
.filter(~Q(...))
to.exclude(...)
.exclude
behaves the same and is the "correct" way to do this sort of query in Djangorest_framework.generics.get_object_or_404
instead ofdjango.shortcuts.get_object_or_404
.typing.Union
andtyping.Optional
with new union type syntaxTechnically, 3) isn't necessarily incorrect (from what I understand,
typing.Optional
andtyping.Union
are not deprecated, at least not yet), but I find thex | y
union syntax to be much more readable. I don't feel strongly on this though 🤷♂️